fibelatti / pinboard-kotlin

Unofficial Android client for Pinboard and Linkding
https://play.google.com/store/apps/details?id=com.fibelatti.pinboard
Apache License 2.0
157 stars 13 forks source link

Any chance of putting this wonderful app on F-Droid store? #11

Open tinylucid opened 3 years ago

tinylucid commented 3 years ago

I would really appreciate it (and I am sure many others).

fibelatti commented 3 years ago

Hi @defphil, thanks for the suggestion. I will look into doing it.

grrrrr commented 2 years ago

I'll second this request, it would be very useful to have on f-droid given that the other android app, pindroid has stalled in development

grrrrr commented 1 year ago

Hi @fibelatti

If f-droid is not an options, would it be possible to release APK on gitbub? It might allow for inclusion with @IzzySoft's repo which can be used with f-droid https://apt.izzysoft.de/fdroid/

IzzySoft commented 1 year ago

Would fit from what I see – if the signed APK were available here (preferably with releases being tagged and the APK files attached to their corresponding release).

fibelatti commented 1 year ago

Hi @fibelatti

If f-droid is not an options, would it be possible to release APK on gitbub? It might allow for inclusion with @IzzySoft's repo which can be used with f-droid https://apt.izzysoft.de/fdroid/

Hey @grrrrr, thanks for suggesting this alternative, I know it's been a good while since adding the app to F-Droid was first suggested. I've looked into it a while back but never managed to go through the full setup required, so this alternative might facilitate things.

I still need to make a few changes to the app because I'm use some play services (to auto-update and prompt for app store reviews). I'll either have to remove those or build a different app flavour that's specific to F-Droid. I'll prioritise this and see what it takes to add it to the repo

fibelatti commented 1 year ago

@IzzySoft I have just released v2 which should be suitable for your repository. I have attached the signed .apk to the release on GitHub, is there anything else I should be doing to have it listed?

IzzySoft commented 1 year ago

I have just released v2 which should be suitable for your repository.

Confirmed: it is :smiley:

is there anything else I should be doing to have it listed?

Just to wait until it shows up here with the next sync around 6 pm UTC :smiley: If you want to define how your app is presented, you could establish Fastlane structures here in your app's repo (be welcome to use my Fastlane Cheat Sheet for guidance with that). And of course you're also welcome to pick a badge to link to your app's new presence :wink:

Thanks a lot!

fibelatti commented 1 year ago

@IzzySoft awesome, thank you! I'll look into setting up fastlane and adding a badge to the repository later today 🚀

IzzySoft commented 1 year ago

Fantastic! Please givve me a ping here once Fastlane is ready – so I cross-check, enable it on my end and (if you link me that RFP I saw a few hours again) also kick the issuebot for another scan at F-Droid.org :wink:

fibelatti commented 1 year ago

@IzzySoft I've setup the metadata for fastlane now and published a new release just in case since F-Droid doesn't build from HEAD. This new tag should also fix the Gradle wrapper issue from the RFP 👀

I'm gonna look into the badges next, thanks for your support

Edit: the Gradle wrapper changes messed up my GHA CI, so let me figure that out Edit 2: it should be sorted now

grrrrr commented 1 year ago

@fibelatti & @IzzySoft this is fantastic, thank you both for getting this available via f-droid clients.

IzzySoft commented 1 year ago

Oof, got no notification for the edits – so thanks @grrrrr for causing this ping :see_no_evil: Bot is triggered now at the RFP.

fibelatti commented 1 year ago

@IzzySoft no problem! As always, thanks a mil for your support!

fibelatti commented 11 months ago

Hey @IzzySoft, I've got two questions and couldn't think of a better way to reach out!

  1. I have setup the metadata, could you please enable that on your side so that my listing on IzzyOnDroid is automatically updated?
  2. I'm about to include com.google.android.gms:play-services-oss-licenses as a dependency to help listing all other OSS libraries I've used. That's the dependency for this plugin and their license points to https://developer.android.com/studio/terms. Do you reckon that would be a problem for IzzyOnDroid/F-Droid because it's a Play Services dependency? If so I'd much rather find an alternative
IzzySoft commented 11 months ago

couldn't think of a better way to reach out!

Totally fine this way :smiley:

could you please enable that on your side

That was already done on 2023-10-02. Changes on your end would be pulled along with new releases.

I'm about to include com.google.android.gms:play-services-oss-licenses

Bad idea. The "oss" in that name is misleading: it only processes FOSS-licenses but is not fully FOSS itself (but will drag in proprietary dependencies like GMS) – those AS-terms are proprietary, too (limiting freedoms). So yes, I'd say that is a problem. Mind to pick one of the alternatives I've collected for you? :wink:

fibelatti commented 11 months ago

@IzzySoft you're a gentleman sir! Thanks for enabling the metadata change and for linking the alternatives! I'll look into them before submitting the next update.

I've also released a new app this weekend but it already contains the play library so I'll remove it first before submitting it to IzzyOnDroid as well.

Thanks a mil Izzy!

IzzySoft commented 11 months ago

You are very welcome! Just give me a ping when your new app is ready. Don't be surprised if I then respond that it's already listed :see_no_evil:

Some background:

Not all is automated, though. So don't you worry I'd get bored – I won't :see_no_evil: