fibercrypto / fibercryptowallet

Multi-coin cryptocurrency wallet
GNU General Public License v3.0
28 stars 15 forks source link

Unify generics code #297

Closed hsequeda closed 4 years ago

hsequeda commented 4 years ago

Fixes #290

Changes: -Added Iterator interface. -Implementing Iterator interface in util packege with GenericIterator type. -Replaced all old iterators implementation for GenericIterator. -Added test and comments for GenericIterator type.

Does this change need to mentioned in CHANGELOG.md? no

Requires testing Requires testing no

Comments about testing , should you have some

olemis commented 4 years ago

@stdevHsequeda good , will take a look into this shortly

olemis commented 4 years ago

I'm starting to hesitate about whether moving forward with this is a good idea

olemis commented 4 years ago

I am not satisfied with the approaches I've seen so far ... Let's keep things the way they are now and reopen this should situation change at some point later