search

fibercrypto / fibercryptowallet

Multi-coin cryptocurrency wallet
GNU General Public License v3.0
27 stars 15 forks source link

History address filter unchecked arbitrarily #348

Closed olemis closed 4 years ago

olemis commented 4 years ago

Describe the bug History filters uncheck themselves

Environment information:

Steps to Reproduce

As a precondition there should be at least one wallet with multiple address already generated.

  1. make clean
  2. make run
  3. Wait for 2 minutes or so
  4. Go to history tab
  5. Eventually some transactions rendered in history list view.
  6. Turn filters on
  7. Click on Select filters
  8. In filter dialog find a wallet with multiple addresses
  9. Select a single address
  10. Click on Close to exit dialog
  11. Click on Select filters once again

Actual behavior In step 9 above only transactions related to checked address remain in list . Nonetheless in step 10 the item for previously selected address is initially checked but but becomes unchecked shortly (few seconds) after.

Expected behavior Filters should not change arbitrarily. Selection should be consistent over time if user does not (un)check items .

Additional context Related to changes merged in #295 . In step 4 transactions might not be rendered due to the issue reported in #347 . Turn filters on and off back again for transactions to show up.

olemis commented 4 years ago

Noticed that this may be related to ordering used in wallet address sub-list . It must match deterministic sequence . @stdevMauricio1802 can you confirm ?

olemis commented 4 years ago

fixed by #350