search

fibercrypto / skywallet-mcu

Skywallet bootloader and firmware
2 stars 5 forks source link

Continuous integration on Windows #342

Open isaacvr opened 4 years ago

isaacvr commented 4 years ago

Feature description

Setup Windows CI

Is your feature request related to a problem? Please describe. After adding Windows support , CI on Windows is needed to detect potential regressions as soon as possible.

Describe the solution you'd like Setup CI on Travis

Describe alternatives you've considered If not possible on Travis then on Appveyor

Additional context Windows support added as part of #326 for #192

Possible implementation See Travis Windows build env spec

stdevPavelmc commented 4 years ago

Testing appveyor builds as travis use git-win shell by default and its a PITA to deal & mix the two linux envs...

stdevPavelmc commented 4 years ago

At this point we need to tweak the Makefile of https://github.com/fibercrypto/skywallet-protob to handle the windows build, as the repo is hard-wired to only linux|osx support and we need Windows support also.

Relevant lines of the makefile are this https://github.com/fibercrypto/skywallet-protob/blob/8ce918b0c1c3d7e3d315ee19e2d097ea4ee78838/Makefile#L15-L35 This need to be improved to support windows builds.

olemis commented 4 years ago

@stdevPavelmc what do you nedd in the Makefile ? why ?

olemis commented 4 years ago

@stdevPavelmc you should add a branch for Windows , just create an issue in protob repository and get that done prior to finishing work on MCU firmware

olemis commented 4 years ago

@olemis when I said branch , I did not mean a Github branch , but a sibling case in conditional statement

stdevPavelmc commented 4 years ago

Yes, your two previous comments is the way I intended to do it.

I need to modify the Makefile because the path of the release protob file from here https://github.com/protocolbuffers/protobuf/releases/tag/v3.6.1 is built with the version and OS name; even so, the windows release file does not follows the naming convention of the unix/osx one.

For example Unix like is protoc-$(PROTOC_VERSION)-$(OS_NAME)-x86_64.zip Windows one is protoc-$(PROTOC_VERSION)-win32.zip

The mod is just related to the detection of the OS to form the URL to the release file.

olemis commented 4 years ago

@stdevPavelmc we'll review that once you submit your patch

stdevPavelmc commented 4 years ago

@olemis PR is ready for review...

olemis commented 4 years ago

@olemis PR is ready for review...

What PR ?