search

fibo / trunx

Super Saiyan React components, son of awesome Bulma
MIT License
64 stars 14 forks source link

Custom element for components #18

Closed andreimc closed 4 years ago

andreimc commented 5 years ago

Allowing us to specify what element should be rendered, there is a lot of advantage in this, similar to what react Bulma components is doing. I had some issues with using this with the navbar a elements within a elements

fibo commented 5 years ago

Hi @andreimc thank you for using trunx!

Do you refer to Bulma's navbar-item which could be an a element or, in case of a dropdown, a div element.

If yes I think it should be easy to fix the Navbar.Item component, which now renders always an a, to render a div element in case the hasDropdown boolean is true.

Is the issue you had related to the Navbar.Item behaviour I wrote above? Feel free to give any advice or suggestion you think it worth. Any feedback is welcome.

fibo commented 5 years ago

@andreimc I am working on that, thanks for the feedback.

fibo commented 4 years ago

navbar component should be fixed