search

fibo / trunx

Super Saiyan React components, son of awesome Bulma
MIT License
64 stars 14 forks source link

Documentation for the modal component. #28

Closed carsnwd closed 3 years ago

carsnwd commented 3 years ago

Added some documentation and examples with code for the modal section. Tried to follow suit mostly with the other component documentations and copy the actual Bulma documentation with the Trunx implementation as best I could.

fibo commented 3 years ago

@carsnwd thank you a lot! Really appreciated!

Usually I try to use Ul, Li, P components instead of builtin ones, this is not an issue at all I will merge it (no action required on your side, again thank you very much).

My goal is to reach 100% documentation coverage then do a revision in a future v1 release (where the major version of Trunx will match the major version of Bulma :^)

fibo commented 3 years ago

@carsnwd

I found the cause of the issue related to the Modal.Card.Header, using a div instead of a p in the component fixes everything.

I just released a new version v0.34.1 with fixes, the Modal page is online here 👍: https://trunx.dev/component/modal