search

fibo / trunx

Super Saiyan React components, son of awesome Bulma
MIT License
64 stars 14 forks source link

Fixing htmlFor property not passing to base label component #62

Closed alexjamesmalcolm closed 1 year ago

alexjamesmalcolm commented 1 year ago

I started using trunx because of the awesome name but I noticed that when I was using the Label component that the htmlFor property was not causing Labels to be associated with Inputs. This PR should fix that by passing the props to the base component.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
trunx ❌ Failed (Inspect) Oct 7, 2023 7:44pm
alexjamesmalcolm commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC) trunx ❌ Failed (Inspect) Oct 7, 2023 7:44pm

I'm not able to view why the build has failed. I will try to build locally and see why may be the issue when I get a chance.

fibo commented 1 year ago

Hi @alexjamesmalcolm

nice catch!! and thank you for your contribution. It should be already available on npm as version v0.45.5.

Regarding the error, I see it is (from ts-server)

A rest parameter or binding pattern may not have a trailing comma.

You can catch it if you clone repo locally and run nom run check_types. Or it gets automatically fixed by (local) pre-commit hook that you get when you run npm install. In case you want to play around with trunx you can find some info here in DEVELOP file.

But thanks again, I merged it and published to npm.

Used also htmlFor here: