search

fibo / trunx

Super Saiyan React components, son of awesome Bulma
MIT License
64 stars 14 forks source link

NavbarBurger support is-active class #63

Closed alexjamesmalcolm closed 11 months ago

alexjamesmalcolm commented 11 months ago

According to the navbar-burger documentation the is-active class should toggle the navbar-burger between a burger and a cross. https://bulma.io/documentation/components/navbar/#navbar-burger

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
trunx ✅ Ready (Inspect) Visit Preview Oct 13, 2023 5:47am
fibo commented 11 months ago

Nice!

somehow I missed it.

Merged it, just added a small modification (using modifier({ isActive }) instead of { "is-active": isActive }, both are valid code though)

I published it on registry as version v0.45.6.

@alexjamesmalcolm if you feel more comfortable I can give you permissions to commit here. I recently removed branch protection, let just agree on avoid pushing to main branch if not necessary, so using common git workflow is welcome.

alexjamesmalcolm commented 11 months ago

Hi @fibo,

Thanks! I would be willing to make commits to branches in this repo. I intend to never touch main. I think that you could give me some permissions without making me a full admin or something. You could make it so that admins can bypass branch protection, make only yourself an admin, and when you need to use special permissions you're able to but other contributors like me could not.

fibo commented 11 months ago

ciao @alexjamesmalcolm , thanks for collaborating!

I sent you an invite.

Usually I prefer to set less rules and follow common sense. Feel free to do any kind of modification, consider that having a Pull Request where we can discuss and review changes is preferred.