Closed m-mohr closed 4 months ago
I'm trying to figure out why the CI fails, stay tuned ;-)
The only thing I still have questions about is the removal of the
verified_until
property. Why have a start date but not an end date?
@hannah-rae I removed verified_until
because I thought it was redundant with determination_datetime
of the core schema. Please let me know if you think otherwise.
determination_datetime
is indeed equal to ml:verified_until
.
Ideally, ml:verified_from
would (later) move into the timestamps extension.
What we should probably do here is to also require fields from the core specification and explain how they relate to the ml: fields.
For example ml:creation_method maps to detemination_methods (and should be required if this extension is used?)
And ml:verified_until
maps to determination_datetime (and should also be required if this extension is used?)
etc.
@m-mohr I do like that idea, although I don't have enough knowledge about schemas to know how to link that – if we do decide on doing so, would you be able to make that change?
CI works again, I had to regenerate the GeoParquet after requiring the two determination_* fields.
Does this make it clearer @hannah-rae ?
@eddiechoi00 One last question: Is ml:creation_date
different per Feature or is this a collection-level property that has a single value for all Features? If the latter is true, we should make it a Collection Property.
Note: The changes were made by @eddiechoi00, I just created the PR for his branch!
The following changes were reported:
Added
Changed
ml:admin1
is a ISO 3166-2 Code for provinces/states.ml:admin2
is a modified HASC-2 Code for counties/municipalities. The modification replaced the.
to-
, to more closely resemble the ISO 3166-2 Codes.Removed