search

fiboa / cli

CLI for fiboa (validation, inspection, schema and file creation, etc.)
https://pypi.org/project/fiboa-cli/
Apache License 2.0
0 stars 7 forks source link

Added france eurocrops converter #31

Closed cholmes closed 6 months ago

cholmes commented 6 months ago

Adding the Eurocrops version of the french government's 2018 boundaries to the converter.

m-mohr commented 6 months ago

@cholmes Could you please review whether my changes make sense and it works for you as intended? For me it looks good for now.

PS: I renamed to ecfr to keep the Eurocrops datasets more closely grouped together, keeping the fr* scope for official datasets from France.

cholmes commented 6 months ago

@cholmes Could you please review whether my changes make sense and it works for you as intended? For me it looks good for now.

Yup, looks great! Thanks for all your work on it. Much cleaner now. I'll go ahead and merge. (I tested it again to make sure it worked and it was great)

PS: I renamed to ecfr to keep the Eurocrops datasets more closely grouped together, keeping the fr* scope for official datasets from France.

Cool. How strongly do you feel about fiboa project names and file names following this same convention? The 2 sets of two of two letters seems fine for me for the converter, but I tend to like file names to be a bit more description.

m-mohr commented 6 months ago

Not so strongly. We could also name it eurocrops_france or so. Should just be consistent in their 'groups', e.g. all eurocrops ones...