fiboa / cli

CLI for fiboa (validation, inspection, schema and file creation, etc.)
https://pypi.org/project/fiboa-cli/
Apache License 2.0
0 stars 6 forks source link

Added South Africa and Germany Fieldscapes Converter #43

Open aninda-ghosh opened 3 months ago

aninda-ghosh commented 3 months ago
aninda-ghosh commented 3 months ago

A couple of questions and suggested changes.

I'm wondering, is crop_id, crop_name and grid_id a common thing in FieldScapes? If yes, an extension would be good to have.

I guess yes but after last meeting we have removed the grid id on the merged dataset. but crop id and crop_name are not consistent in the subset (So Need Discussion on this further )

m-mohr commented 3 months ago

Happy to help with the extension. Do you want to give it a shot for a first draft?

m-mohr commented 3 months ago

Please rebase the PR to the latest CLI version, including renaming the URI constant to SOURCES and renaming the parameter cache_file to cache. I tried to push it upstream, but you didn't permit changes to this PR so you need to do these changes yourself. Thanks.