search

fiboa / cli

CLI for fiboa (validation, inspection, schema and file creation, etc.)
https://pypi.org/project/fiboa-cli/
Apache License 2.0
0 stars 7 forks source link

Update ec_si.py #71

Closed DanielNwaeze closed 4 months ago

DanielNwaeze commented 4 months ago

Modified based on latest cli changes for commit

m-mohr commented 4 months ago

While you are at it, would you mind adding a test similar to the ones we have?

Will merge nevertheless now, changes look good, thanks.

DanielNwaeze commented 4 months ago

I don't see steps to creating tests on the repo. Maybe we add something clear in the Readme?

m-mohr commented 4 months ago

That's something relatively new, we should indeed update the Readme. => #72

DanielNwaeze commented 4 months ago

what do we include for the data files for eurocrops datasets ec_fr and ec_si? no gpkgs are contained in the data. do we convert the .shp file to .gpkg file? and wouldn't that consume a large amount of data?

m-mohr commented 4 months ago

We can create a subset of the data using ogr. See the test file for the command.