Closed stitzelj closed 7 years ago
There is also a wider issue here, which is the division between development and operations. The source control mechanism is a development tool, in which we are developing a piece of software (let's call it "main", as that's the name of the repo).
At some point, Paul is going to take the code in source control and copy it onto the server. This is operations, which is the practice of maintaining a particular hardware and software combination (Linux, Python, database, etc.) required to run "main". This creates the website we know as "Ficlatte".
The reason I reject adding Bootstrap to source control is that the decision of Bootstrap versions is very much in the realm of operations, and so does not belong in the development tool of source control. In the same way, we wouldn't check in the MySQL binaries, or the Linux distribution (extreme examples to clarify my point).
Good point. I wasn't sure what was the best approach there, so I've pulled out the dependencies for this PR.
A limited number of files in /castle/static/css are still contributing multiple-thousands of lines.
Ok, let me look at the code again and see if the datepicker can use the existing bootstrap files without loss of function. If so, I'll pull those additional dependencies out, as well, and continue with what we have already.
My suggestion: take all that out, and note in the comments somewhere that the server deployment needs these things.
Or we could write an install script that automatically deploys the latest version of Bootstrap.
Ok, I made the additional changes. I probably should have checked all that out before initially committing (meant to, in fact, but forgot). This should be cleaner and leaner.
At the time of commenting, there are 9,803 lines of code under source control. I don't feel comfortable approving a pull request that doubles the size of the repository in order to add a relatively minor feature.
I will add, as an aside, that I am planning to give both the prompts and the challenges sections a 'front page' layout similar to the index at some point.
Looks nice at home. I'll update the production site as soon as I can.
Here's the completed challenge module. I've debugged it as thoroughly as I can, so if you guys stumble across something, let me know.
Some notes:
Let me know if there's anything I missed for integrating this into prod. This ended up being a pretty intricate module, so I may have overlooked something in the notes above.