search

fictiveworks / CalyxSharp

Generative text processing for C# and Unity applications
Other
0 stars 0 forks source link

rewrite constructors to resolve ambiguity with RNG and seed params #20

Closed bentorkington closed 1 year ago

bentorkington commented 1 year ago

As described in #18, constructors for Options and Grammar have some ambiguity around passing pre-initialized RNGs and seeds.

This PR provides separate initializers for each use case and makes use of initializer chaining to tame the constructor signatures.

maetl commented 1 year ago

Feel free to merge this whenever you’re happy with it.

bentorkington commented 1 year ago

cool cool, I accidentally set this PR up to merge into the wrong branch