search

ficusio / openresty

Lightweight OpenResty Docker image
132 stars 37 forks source link

ONBUILD hook problems #13

Open SerialVelocity opened 8 years ago

SerialVelocity commented 8 years ago

Hey,

I've been trying to use this docker image (It's great btw!) but I'm encountering a rather annoying thing. I only want to inject an nginx.conf but that doesn't seem to be possible as I need to inject mime.types, fastcgi.conf, etc. Is it possible to either make it possible to disable the hook or just remove it entirely?

I think that users having to write one line so that their nginx configuration is added is perfectly fine.

Cheers, SerialVelocity

skozin commented 8 years ago

Hi,

You're right, this may be quite confusing. What do you think about me splitting this image into two tags, e.g. base and onbuild (which is based on base and adds onbuild hooks), like in this image?

One thing to keep in mind is that, in this case, I'll have to alias latest to onbuild, not base, to maintain backwards compatibility, so you'll need to specify base as the tag to get rid of the hooks.