search

ficusjs / ficusjs-i18n

Functions for managing translations and localization in FicusJS components
MIT License
1 stars 1 forks source link

feat: implemented automatic maintenance of the 'lang' attribute on components with reactive i18n #58

Closed mesr closed 1 year ago

mesr commented 1 year ago

No surprise, pretty much as proposed. I took the opportunity to fix the app-with-18n-reactive e2e test that was not performing its last locale switching.

(this PR implements proposal #56)

mesr commented 1 year ago

For sure, I'll have a look. Thanks for pointing it out.

ducksoupdev commented 1 year ago

I have added a Github workflow for running PR checks - that should help with subsequent work :)

mesr commented 1 year ago

There seems to be an issue with NPM dependencies. I ran into the same issue on my dev server when running npm install after cloning the repo; had to --force install.

ducksoupdev commented 1 year ago

There seems to be an issue with NPM dependencies. I ran into the same issue on my dev server when running npm install after cloning the repo; had to --force install.

@mesr there was a dependency issue. I have fixed it in the main branch so if you rebase your branch, it should be fine.

mesr commented 1 year ago

Ah ok, I see. I think it should be fine now.