fidelity / spock

spock is a framework that helps manage complex parameter configurations during research and development of Python applications
https://fidelity.github.io/spock/
Apache License 2.0
122 stars 13 forks source link

Fix missing classes in spockspace #201

Closed ncilfone closed 2 years ago

ncilfone commented 2 years ago

What does this PR do?

New graph backend from #181 was causing translation from Spockspace to native python dictionary to fail in certain cases: (1) optional Enum's of @spock decorated classes, (2) nested @spock classes with definitions coming in from configuration file(s) -- as these were not getting recursed in the config check.

This PR solves both the above issues and adds additional unit tests.

Checklist

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1679181498

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Files with Coverage Reduction New Missed Lines %
spock/backend/field_handlers.py 3 92.36%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 1650853062: 0.03%
Covered Lines: 1615
Relevant Lines: 1699

💛 - Coveralls