fidelity / spock

spock is a framework that helps manage complex parameter configurations during research and development of Python applications
https://fidelity.github.io/spock/
Apache License 2.0
122 stars 13 forks source link

graph equality bug #202

Closed ncilfone closed 2 years ago

ncilfone commented 2 years ago

What does this PR do?

fix bug where equality was checking using is (which checks memory loc) which prevents class overloading and re-mapping. Switched to a simple module + class name mapping as those should still be unique

Checklist

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1683899334

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1679196849: 0.2%
Covered Lines: 1616
Relevant Lines: 1700

💛 - Coveralls