Closed ncilfone closed 1 year ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
spock/backend/resolvers.py | 74 | 75 | 98.67% | ||
spock/utils.py | 5 | 6 | 83.33% | ||
spock/backend/typed.py | 15 | 17 | 88.24% | ||
spock/graph.py | 164 | 168 | 97.62% | ||
spock/backend/validators.py | 81 | 94 | 86.17% | ||
<!-- | Total: | 432 | 453 | 95.36% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
spock/backend/builder.py | 1 | 99.11% | ||
spock/graph.py | 1 | 97.41% | ||
spock/backend/resolvers.py | 2 | 97.37% | ||
spock/backend/saver.py | 4 | 95.65% | ||
spock/backend/utils.py | 5 | 92.92% | ||
spock/backend/payload.py | 15 | 82.88% | ||
<!-- | Total: | 28 | --> |
Totals | |
---|---|
Change from base Build 2511258184: | -0.8% |
Covered Lines: | 2461 |
Relevant Lines: | 2586 |
@brianwarner Need reviewer approval for merge to master. Also can't cut a new release via a tag (which will trigger the build/push to pypi) since I don't have permissions. This should be the 3.0 release as there is a non backwards compat feature.
Any chance you've figured out Fidelity's view on outside collaborators being able to review/merge/release? Need a path to sustainability here as I've picked back up development... Trying to avoid forking spock and maintaining it outside of Fidelity OSS
What does this PR do?
${spock.var:SpockClass.defined_variable}
. Closes #243List
of repeated@spock
decorated classes.Checklist