fidelity / spock

spock is a framework that helps manage complex parameter configurations during research and development of Python applications
https://fidelity.github.io/spock/
Apache License 2.0
121 stars 13 forks source link

Fix: Bug in Optional of GenericType #274

Closed ncilfone closed 1 year ago

ncilfone commented 1 year ago

What does this PR do?

fixed bug in allowing inherited GenericType to be optional. since the typing.Optional annotation is stripped off of the parents we needed to pass on the optional metadata to override the typing check.

Checklist

Review

Request will go to reviewers to approve for merge.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3989948748

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 3959887721: 0.1%
Covered Lines: 2526
Relevant Lines: 2654

💛 - Coveralls