Issue #296 - Githubissues

ncilfone commented 1 year ago

What does this PR do?

Attempting to fix #296. Seems like the general SO info points to windows system needing stdin even as a null device. Other fix seems like it could be leaky resources from GitPython for long running processes. Make sure to call close() to help prevent resource leak. Also bump all the github actions ubuntu version to 20.04 since 18.04 got deprecated

Checklist

[x] Did you adhere to PEP-8 standards?
[x] Did you run black and isort prior to submitting your PR?
[x] Does your PR pass all existing unit tests?
[x] Did you add associated unit tests for any additional functionality?
[x] Did you provide code documentation (Google Docstring format) whenever possible, even for simple functions or classes?
[x] Did you add necessary documentation to the website?

ncilfone commented 12 months ago

@mmalouane Can you merge this and cut a new release with a minor version bump (3.1.0) -- handling python 3.6 deps and pyyaml specifically are breaking installs currently on 3.10

thomaselee commented 9 months ago

Is there any update on when this build (3.6) expectation can be removed? We're currently blocked from using any python 3.10 images in AWS SageMaker until we get an updated version of spock

ncilfone commented 9 months ago

@thomaselee See #279 that now merges the fix to #296 into some other functionality. Trying to get @mmalouane to approve and release

fidelity / spock

Issue #296 #297

What does this PR do?

Checklist