Closed wesray closed 11 years ago
Thanks ill check it out!
Good idea using the code repo!
No worries, I didn't want to put you on blast from Twitter, heh. If I find anymore, I'll toss them on here.
Cheers.
FYI, I plan on getting to this and some other feedback I received this weekend.
Thanks again
Pages 27,43 (and maybe more?) - effecting should be affecting Page 33 - Implemeting should be Implementing Page 36 - event should be even Page 41 - over-ride should be override Page 47 - namspace should be namespace
I'll document more here as I make progress. Cheers.
Thanks, these are all fixed (Update to be released soon)!
Page 39:
$this->article->byPage($page, $rpp);
$rpp should be $perPage
Just fixed that and published the fix, thanks!
Wow! You are fast :+1: Here is another one on page 51:
$cached = $this->cache->put(
should be:
$cached = $this->cache->putPaginated(
On page 53 you forgot to include TagInterface
return new EloquentArticle(
new Article,
new LaravelCache($app['cache'], 'articles', 10)
);
and that should be:
return new EloquentArticle(
new Article,
$app->make('Impl\Repo\Tag\TagInterface'),
new LaravelCache($app['cache'], 'articles', 10)
);
It is easier for me to write this one by one as I find them. It's not just to spam your inbox :)
On page 59 you defined:
abstract class AbstractLaravelValidator
and on page 61 you extended ArticleFormValidator with that abstract class but with different name:
class ArticleFormValidator extends LaravelValidationAbstract
Name them whatever you want but they should be the same :)
I slowed down apparently lol - I'll take care of these soon!
Thanks
I've updated and just clicked publish from your list. If you wouldn't mind opening a new ticket for any further typos, that'd be appreciated
Thanks again!
Page 8 of the e-book: App::make('paginator']