search

fideloper / docker-nginx-php

An Ubuntu, Nginx and PHP stack Built in Docker
361 stars 142 forks source link

Tip: Cleanup Dockerfile #14

Closed sammcj closed 9 years ago

sammcj commented 9 years ago

(Redacted stupid wording on my behalf) I'm not actually using this, but I thought I'd suggest a few things (that you will need to test) to help improve your Docker experience.

Further suggestions:

sammcj commented 9 years ago

Note: Do not merge this as-is, feel free to check it out and learn from it / fix it and make it better for yourself - just trying to help out.

fideloper commented 9 years ago

Uh, right. I mean, I appreciate it, I guess, except for the condescension.

I should expand on that - this is a 1 year old repository. I've learned a lot more about docker since It's been created. This just feels condescending based on your assumption that it represents my current usage of Docker. I can see how your just trying to help...other than calling the code disgusting :P

This was my first stab at docker, unused on my end. I'd blow it away if I didn't think the few who PRed to it might be using using it.

I'd otherwise agree with you in your points. I just don't care to maintain this, so I'll either delete it or note that in a readme.

May I ask how you came across this? I might have linked it from a SFH article which I could see leading you to believe that I think it's relevant still.

Thanks On Mon, Feb 23, 2015 at 01:48 Sam notifications@github.com wrote:

Note: Do not merge this as-is, feel free to check it out and learn from it / fix it and make it better for yourself - just trying to help out.

— Reply to this email directly or view it on GitHub https://github.com/fideloper/docker-nginx-php/pull/14#issuecomment-75500545 .

sammcj commented 9 years ago

Oh my, I don't know what I was thinking when I wrote that - please accept my sincere apologies for my wording there - I was on a roll cleaning up some docker files I had then I needed a Nginx php image to test something really quickly internally - saw this and thought 'I'll just make a few quick cleanup changes...'

I shouldn't have used the word disgusting - but my intentions were good - sorry to oftend (- I'm embarrassed I wrote that.

fideloper commented 9 years ago

Hey Sam!

I appreciate you writing back, I had a feeling you didn't mean it like that, but I guess that's how it sounded to me.

No harm done!

I do totally agree with your points, but in the end I just don't care enough (or more accurately, have the time care) about this repo to take action and make changes to it (I think some users might be using it, and expect it to work this way, but I'm not sure on usage at all).

When I get more free time to come back to Docker stuff I'll probably create a few new ones which are more inline with these ideas. (We'll see ! So far I haven't used it in production much, I haven't had the need to really containerize stuff in production in a day to day job or side project).

Thanks for hearing me out :D

On Mon Feb 23 2015 at 1:44:08 PM Sam notifications@github.com wrote:

Closed #14 https://github.com/fideloper/docker-nginx-php/pull/14.

— Reply to this email directly or view it on GitHub https://github.com/fideloper/docker-nginx-php/pull/14#event-240402207.