search

fideloper / docker-nginx-php

An Ubuntu, Nginx and PHP stack Built in Docker
361 stars 142 forks source link

Added noninteractive for apt-get installs #18

Closed BlackthornYugen closed 9 years ago

BlackthornYugen commented 9 years ago

This prevents a lot of the error messages during install that begin with "debconf: unable to initialize frontend: Dialog". screen shot 2015-05-10 at 1 30 43 pm This likely doesn't make any functional difference but it would make it easier to spot actual problems during a docker build.

fideloper commented 9 years ago

Howdy! Looks like a lot of your commits are coming through here, some specific to your repository instead of this one!

(However I'd love to pull in the noninteractive bit!)

BlackthornYugen commented 9 years ago

Sorry about that, this was my first cross-repo pull request. I guess I did something wrong. Let me try again.

fideloper commented 9 years ago

No problem! (I think it keeps adding commits as you make them to the branch used for the PR, I forget if there's a way to stop that other than making a branch specifically to PR from)

On Mon, May 11, 2015 at 7:09 AM John Steel notifications@github.com wrote:

Sorry about that, this was my first cross-repo pull request. I guess I did something wrong. Let me try again.

— Reply to this email directly or view it on GitHub https://github.com/fideloper/docker-nginx-php/pull/18#issuecomment-100887841 .

BlackthornYugen commented 9 years ago

Right, thats what it looks like. I wonder if I do that and then deleted the pulled branch, would it mess anything up?

fideloper commented 9 years ago

I'm ~90% sure that'll work fine

BlackthornYugen commented 9 years ago

Yup! #19 still shows that it was pulled from the branch even after it was deleted. I thought maybe it might say that it pulled from master or possibly stop tracking the history after deleting the branch.

fideloper commented 9 years ago

Glad it didn't, github is pretty snazzy !

On Mon, May 11, 2015 at 10:18 AM John Steel notifications@github.com wrote:

Yup! #19 https://github.com/fideloper/docker-nginx-php/pull/19 still shows that it was pulled from the branch even after it was deleted. I thought maybe it might say that it pulled from master or possibly stop tracking the history after deleting the branch.

— Reply to this email directly or view it on GitHub https://github.com/fideloper/docker-nginx-php/pull/18#issuecomment-100941058 .