Attempt to detect and discard misbehaving devices

fidesmo / nordpol

The Android Support Library for NFC

MIT License

53 stars 10 forks source link

Attempt to detect and discard misbehaving devices #45

Closed ghost closed 8 years ago

ghost commented 8 years ago

Try to detect failing ISO compatible devices by sending a SELECT command
If failing, discard the tag rather than dispatching it

ghost commented 8 years ago

@slomo What do you think? It is helping on the S6, maybe not as well as the foregroundDispatch NDEF check made by Android, but it filters out some false positives when I use it with the Yubikey.

ghost commented 8 years ago

One option would be to add more conversation here, but it's hard to know what more we could do that will be supported on all ISO devices.

slomo commented 8 years ago

Well you could check for Ndef of course ;)

ghost commented 8 years ago

@slomo But I guess that would on most devices that don't have an NDEF applet just involve the select that fails.

ghost commented 8 years ago

But yeah, it would be as good as the google NDEF check.

slomo commented 8 years ago

:+1: