search

fidesmo / nordpol

The Android Support Library for NFC
MIT License
53 stars 10 forks source link

Move SVG files #71

Closed Franzaine closed 7 years ago

Franzaine commented 7 years ago

As reported by @Valodim #70 the SVG source files were in the library itself bloating it with unnecessary images. This PR moves the files from the asset folder of the Android project to the new folder img-resources that is located in the root folder of the project. This the resources are not in the library itself but they're available when looking at the source of the library here on GitHub.

Result: 2862 kB before 540 kB after

sergkh commented 7 years ago

@Franzaine Why do we need those resources here at all? It seems they too Fidesmo specific to use by anyone else

Franzaine commented 7 years ago

@sergkh They were added to provide the source of the graphics used in the library so that anybody can re-build the library from scratch and tweak any graphics. It was requested long ago by a 3rd party that all sources should be available, even graphics. (We can ofc revisit this decision :) )

sergkh commented 7 years ago

OK, let's leave them then.