search

fidian / hexmode

Vim plugin to edit binary files in a hex mode automatically.
147 stars 19 forks source link

Correct event type to exclude gzipped help files #25

Closed tafryn closed 7 years ago

tafryn commented 7 years ago

The comment above this line correctly called out the BufReadPost event type, but the executed auto command was using BufReadPre.

fidian commented 7 years ago

Thanks for the update. I saw where this got added and the comment clearly doesn't agree with the code. Sorry for not spotting and questioning it at the time.

chaoren commented 7 years ago

It was correct until this change: https://github.com/fidian/hexmode/commit/7a1610faa03afc3aeb3b58fedec8bf08a0cdc772, because after that change b:allow_hexmode would get overwritten. But since we're doing the checking in BufReadPost now we can probably get rid of the flag and do the check directly.