provide error message if using an unsupported tensorflow version

fidler-lab / polyrnn-pp

Inference Code for Polygon-RNN++ (CVPR 2018)

GNU General Public License v3.0

736 stars 161 forks source link

provide error message if using an unsupported tensorflow version #12

Closed chrisrapson closed 6 years ago

chrisrapson commented 6 years ago

demo_inference.sh seems to work with tensorflow versions 1.3.0 to 1.4.2 so I allow anything in that range. I have tested by running demo_inference.sh using tensorflow versions 1.2.0, 1.3.0, 1.4.2, 1.5.0, 1.8.0.

amlankar commented 6 years ago

Lgtm. I will wait for the others to also take a look before merging.

Thanks!

amlankar commented 6 years ago

On second thought, since we developed and tested extensively on tf1.3, I would be more comfortable with it only being allowed on 1.3, since I don't know if any other semantics changed which might affect further releases. Could we please change that?

Thanks!

amlankar commented 6 years ago

Lgtm, thanks!