fidley / ABAPFavorites

ABAP Favorites Eclipse Plugin
https://abapblog.com
37 stars 6 forks source link

View not available #82

Closed bilbon-s closed 1 year ago

bilbon-s commented 2 years ago

Hello Lukasz,

Thanks for this great extension. I have a problem with the latest eclipse version (2021-12 (4.22.0)). The extension is installed but the view is not available to add. Never had any problem with previous versions.

Do you have any idea of the problem ?

Reading the logs I could find this : !ENTRY org.eclipse.equinox.p2.engine 2 0 2021-12-22 11:14:00.253 !MESSAGE !SUBENTRY 1 org.eclipse.equinox.p2.touchpoint.eclipse 2 0 2021-12-22 11:14:00.254 !MESSAGE Failed to find a configured bundleInfo for: [R]com.abapblog.favorites 1.0.60. !SUBENTRY 1 unknown 0 0 2021-12-22 11:14:00.254 !MESSAGE OK !SESSION 2021-12-22 11:14:03.545 ----------------------------------------------- eclipse.buildId=4.22.0.I20211124-1800 java.version=17.0.1 java.vendor=Eclipse Adoptium BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=fr_CH Framework arguments: -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.java.product -product org.eclipse.epp.package.java.product -data file:/C:/Eclipse_workspace/ -product org.eclipse.epp.package.java.product and this :

!ENTRY org.eclipse.equinox.p2.repository 2 0 2021-12-22 11:29:27.447 !MESSAGE Using unsafe http transport to retrieve http://abapblog.com/eclipse/plugin/ABAPFavorites, see CVE-2021-41033. Consider using https instead.

Best regards

fidley commented 2 years ago

Hi @bilbon-s ,

that's odd. I use version 2021-12 and it works for me. Also for my colleagues. Have you tried to run the eclipse with the -clean addition?

Sometimes after installing new version and using old workspace it needs to be run like this. PLease run it ant let me know.

Cheers Łukasz

fidley commented 2 years ago

For the second issue, I guess I will need to move the update site to github o move back the SSL on my website for it. But this was making lots of issues in the past.

fidley commented 2 years ago

For the SSL issue you could try with this Update Site -https://raw.githubusercontent.com/fidley/ADTPluginsUpdateSite/master/Update Site/site.xml I will make it default when I'll test some installations

bilbon-s commented 2 years ago

Hi, Thanks for your answer. Just tried with -clean without success. I tried to do a clean install just in case but have the same result.

No problem with the other extensions (classic outline, adt extension...)

Too bad for me !

fidley commented 2 years ago

damn. Which Java version are you using?

fidley commented 2 years ago

I think its 17.01

bilbon-s commented 2 years ago

Yes 17.0.1

fidley commented 2 years ago

Can you tell me which package of the IDE version exactly are you using? The Java is SAPMachine or any other distribution? I"d like to repeat the tests on my side ;)

bilbon-s commented 2 years ago

I installed "Eclipse IDE for Java Developers" 64 bits windows version installed from the eclipse installer. Version: 2021-12 (4.22.0) Build id: 20211202-1639

The java version is the one included with this version of eclipse : open jdk 64bits jre 17.0.1 v20211116-1657

Didn't try with SAPMachine, I won't have time today but I will try tomorow.

Thanks !

fidley commented 2 years ago

Seems to work on my PC :( image

image

image

fidley commented 2 years ago

Could you sent the full error ? Maybe I will be able to find something there.

bilbon-s commented 2 years ago

Hello Lukasz, Sorry for the delay. I tried with SAP Machine today, and also tried another package (eclipse for php dev). Unfortunately I have the same problem, no view available.

I had this in the log when installing : !ENTRY org.eclipse.equinox.p2.artifact.repository 2 0 2021-12-23 13:03:52.132 !MESSAGE No digest algorithm is available to verify download of osgi.bundle,com.abapblog.favorites,1.0.60. !SESSION 2021-12-23 13:04:01.847 ----------------------------------------------- eclipse.buildId=4.22.0.I20211124-1800 java.version=17.0.1 java.vendor=SAP SE BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=fr_CH Framework arguments: -product org.eclipse.epp.package.php.product -product org.eclipse.epp.package.php.product -product org.eclipse.epp.package.php.product Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.php.product -product org.eclipse.epp.package.php.product -data file:/C:/Eclipse_workspace/ -product org.eclipse.epp.package.php.product

But then no more error in the log. In the installation details I can see Abap favorites.

I don't understand ;-(

Thanks !

MDagni commented 2 years ago

Hi @fidley .

I installed eclipse 2022-06 today and I got the same problem. None of your views are available. Then I found the solution 😉

While installing eclipse, I wanted it to go under C:\Program Files\SAP\ADT folder. But since it requires administrative access, I ran the installer (eclipse-inst-jre-win64.exe) using "Run as administrator" option. Then I started eclipse through the installer and installed ADT extensions.

I quit eclipse, started again as normal user, installed ABAP Favorites. Even though the installation was successful, the views didn't appear. At this point I think it's because the installation folder requires administrative access, your plugin cannot load successfully.

Then I moved eclipse to my user folder (C:\Users\Mehmet\APPS\ADT\eclipse) and re-installed ABAP Favorites and its sisters. Now they work perfectly 😃

fidley commented 2 years ago

@MDagni Thanks for the info! I have always eclipse in my own folder (not system one), that's why I had never the issues. But were the standard ADT plugins working? I cannot imagine why my views were not.

MDagni commented 2 years ago

Yes the standart ADT plugins were working.

With my previous installation of 2021-09, it was also installed in the Program Files directory and your plugin was working fine. May be I did something to gain write access to the installation folder. I remember modifying eclipse.ini file, so probably I gave myself write access on the folder.