Falv Mass Replace bug: dump entering non-numeric chars to a numeric field

[SantiMorenoSAP]

First of all thanks again for this greatly class. I´ve found a bug in the Mass replace functionality. If we have a numeric column, and we try to replace it with a non numeric character a dump is thrown. The dump is originated in function Z_FALV_MASS_REPLACE, in the assigment of the Mass Replace field screen to the ALV tab:

= -low. I think this line can be commented as there is a few lines later a call to an ALV method to do the assigment again. io_grid->set_delta_cells What do you think?

[fidley]

Hi Santi, thanks a lot for your input in version 7.31 !

Well you might be right. I'll do some tests and if they are succesfull then I'll update it. Or you already did the tests? Cheers Łukasz

[SantiMorenoSAP]

I did some test but It didnt work. Maybe an error management popup log could be.

El 20 feb. 2017 21:41, "Łukasz Pęgiel" notifications@github.com escribió:

Hi Santi, thanks a lot for your input in version 7.31 !

Well you might be right. I'll do some tests and if they are succesfull then I'll update it. Or you already did the tests? Cheers Łukasz

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fidley/falv/issues/38#issuecomment-281176799, or mute the thread https://github.com/notifications/unsubscribe-auth/AHxcL-X2sBVnzaZhvzBZPGJvBYZVyXA7ks5refpwgaJpZM4MGNeX .

[fidley]

Ok Then I'll do some additional tests on my own and I'll come back to you. At the end we can check the type of field symbol if is the same to the type of -low, but I'd like to avoid it as this could be time consuming if done wrong. Definitelly a buffer table for the RTTS type object would be needed for each column. Then when types aren't the same I could omit passing -low value to but still pass it o set_delta_cells.

Let's see.

[fidley]

Hello Santi, I've check the code and also I've test a lot and I couldn't repeat the dump. But I remove direct assignment of data to result table as this is risky, as we could have some rules applied in event on_data_change and then this would omit this rules. I've checked with demo program 08 and everything works fine. If I have NUMC field then on selection screen you cannot enter anything than numbers, the same for decimals and integer. Maybe this occurs only on older systems? Cheers Łukasz

[SantiMorenoSAP]

It seems this is only for older system.

2017-02-27 21:23 GMT+01:00 Łukasz Pęgiel notifications@github.com:

Hello Santi, I've check the code and also I've test a lot and I couldn't repeat the dump. But I remove direct assignment of data to result table as this is risky, as we could have some rules applied in event on_data_change and then this would omit this rules. I've checked with demo program 08 and everything works fine. If I have NUMC field then on selection screen you cannot enter anything than numbers, the same for decimals and integer. Maybe this occurs only on older systems? Cheers Łukasz

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fidley/falv/issues/38#issuecomment-282841784, or mute the thread https://github.com/notifications/unsubscribe-auth/AHxcL9M7JC8hKIlq4F30FR8lOsA3RxYMks5rgzDPgaJpZM4MGNeX .

[fidley]

Ok, I'll see if I can test it on some lower system. I guess my 7.31 on windows should still work. I'll keep you informed.

[fidley]

Santi, I've finally did a tests on 7.30 SP12 and using ZDEMO_FALV13 everything was working fine for NUMC fields. I was updating SPFLI-CONNID. Sorry but I cannot repeat it anyhow.

[fidley]

Falv for 7.31 is in separate repository now.