fidley / falv

FALV - Fast ALV Grid
https://abapblog.com
GNU General Public License v3.0
141 stars 52 forks source link

Not passing parameter #55

Closed PShumilov closed 4 years ago

PShumilov commented 5 years ago

Hello! It needs to correct method create_by_type. When calling a method create passing i_applog_embedded = abap_false and i_applog_embedded = abap_false. I think it sholud be like this:

    rv_falv = zcl_falv=>create(
      exporting
        i_parent          = i_parent
        i_applogparent    = i_applogparent
        i_popup           = i_popup
        i_applog_embedded = i_applog_embedded
        i_subclass        = i_subclass
      changing
        ct_table          = <table>
    ).

It's impossible to create object using necessary popup and applog_embedded parameters different from abap_false now.

fidley commented 5 years ago

Thanks @PShumilov , I'll change it as soon as I will get working system again.

fidley commented 5 years ago

Should be now OK :)