fidley / falv

FALV - Fast ALV Grid
https://abapblog.com
GNU General Public License v3.0
141 stars 52 forks source link

alv-grid-merge-cells #77

Closed RTagliento closed 1 year ago

RTagliento commented 1 year ago

As reuqested....

I merged the method of this project https://github.com/tricktresor/alv-grid-merge-cells

I just ADDED without any problem the 5 method of ZTRCKTRSR_GUI_ALV_GRID_MERGE to ZCL_FAVL

Z_DISPLAY Instance Method Public Z_INIT_CELL_STYLES Instance Method Public Z_SET_CELL_STYLE Instance Method Public Z_SET_FIXED_COL_ROW Instance Method Public Z_SET_MERGE_HORIZ Instance Method Public Z_SET_MERGE_VERT Instance Method Public

fidley commented 1 year ago

Hi @RTagliento, I looked on this PR and for me it is reasonable to rewrite the code a bit, to not have two different display methods. I'll try to make it this week. Cheers Łukasz

RTagliento commented 1 year ago

That sound great and good ... I am Happy.

Thank you.

SantiMorenoSAP commented 1 year ago

You are all big!

El dom, 6 ago 2023, 17:55, RTagliento @.***> escribió:

That sound great and good ... I am Happy.

Thank you.

— Reply to this email directly, view it on GitHub https://github.com/fidley/falv/pull/77#issuecomment-1666903649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6FYLYKTKJHUEC477P6LBDXT647DANCNFSM6AAAAAA3DFBIBI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fidley commented 1 year ago

79 I've added the code in a bit different way. All method are without Z_* prefix, Z_DISPLAY is called redraw_after_merging_change and it's called automatically one time, when you adapt the merging on the cell in the new FALV event BEFORE_FIRST_DISPLAY. The handler for this event is added and can be redefined like in the ZDEMO_FALV27 program, could you please check it @RTagliento ?

RTagliento commented 1 year ago

Great!

Tomorrow I will use soon this new version! 😄

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

RTagliento commented 1 year ago

It is working and I am in progress.... thank you a lot!

horizontal merge works.....

next step vertical merge and DROPDOWN

image
fidley commented 1 year ago

Looks like an Excel file 😁

RTagliento commented 1 year ago

vertical merge is ok.... dropdown too ;)

image

fidley commented 1 year ago

Perfect, thanks a lot!

RTagliento commented 1 year ago

Hi Łukasz, extra question/opinion.

I know that into ALV cell we cannot have wrapped words. Do you confirm?

I resolved doing this: image

but as you can see.... that are 2 cells and not one merged as the others.

fidley commented 1 year ago

As far as I know, word wrap is not allowed in grid cells. I've never seen it and never seen the variables or methods that would allow that in ALV Grid or Tree.

RTagliento commented 1 year ago

Thanks about this confirmation. ;)