fidley / falv

FALV - Fast ALV Grid
https://abapblog.com
GNU General Public License v3.0
136 stars 49 forks source link

Syntax Error on Hana 2023 #85

Open jani80k opened 4 months ago

jani80k commented 4 months ago

SAP_BASIS 758 0001 SAP_ABA 75I 0000 S4CORE 108 0000 - S/4HANA Core Applications 1

grafik

jani80k commented 4 months ago

I am in the course of doing a release upgrade from Hana 2020 to Hana 2023. On the Hana 2020 system, this code is not executed, when I start my report. On the Hana 2023 system, this code is passed and throws a shortdump. I downloaded the latest version of ZCL_FALV from github and cannot compile it, unless I comment the line. My report works when I comment the line but I am not sure if I can leave it like that. That line must be there for a reason.

fidley commented 4 months ago

I think it was added in one of the latest changes to omit one dump, when developer was trying to refresh toolbar which was not yet initialized. I'd say it's should be fine to comment it, as I'm still using the version without it on few systems, but could be also an option to check if there is no replacement for that for version 2023. Unfortunatelly I don't have an access to 2023 yet, to check it.

jani80k commented 4 months ago

Looks like that is what SAP themselves are doing.

grafik grafik grafik

jani80k commented 4 months ago

Unfortunately I have not so much knowledge about ALV grids, which is why I am using your nice and easy to use FALV. If you want I could set up a teams call and let you do some tests on my HANA 2023 System.

fidley commented 4 months ago

Could be good idea. But as this variable is deleted now, I would comment there for the moment. I know it was setup in the set_ready_for_input method before, but they must have change a lot inside :) image

jani80k commented 4 months ago

Ok, if you want, you can close the issue... unless you want to keep it open for some reason.

fidley commented 4 months ago

I'll leave it open and I'll come back to you for the short session in next weeks :)

jani80k commented 4 months ago

Is there a way to DM you my work email?

fidley commented 4 months ago

You can use twitter @ abapblog or LinkedIn https://www.linkedin.com/in/lukaszpegiel/, that would be most secure :)

Hhpy410 commented 3 months ago

Hi ,@fidley
The same thing happens to me. What's the solution

fidley commented 3 months ago

Comment the line for the moment.