TPM registration responses in v1.6.33 appear to have invalid cert path

MasterKale commented 3 years ago

FIRST PRE CHECK

[x] I SOLEMNLY SWEAR THAT I HAVE SEARCHED DOCUMENTATION AND WAS NOT ABLE TO RESOLVE MY ISSUE

What protocol are you implementing?

[x] FIDO2 Server
[ ] CTAP2.0
[ ] CTAP2.1
[ ] UAF 1.1
[ ] U2F 1.1
[ ] U2F 1.2

NOTE: UAF 1.0 certification have been officially sunset. U2F 1.2 only supported version of U2F.

What is your implementation class?

[ ] Security Key / FIDO2 / U2F authenticators
[x] Server
[ ] UAF Client-ASM-Authenticator combo
[ ] UAF Client
[ ] UAF ASM-Authenticator

If you are platform authenticator vendor, please email conformance-tools@fidoalliance.org

What is the version of the tool are you using?

v1.6.33

What is the OS and the version are you running?

For desktop tools

[x] OSX
[ ] Windows
[ ] Linux

For UAF mobile tools

[ ] iOS
[ ] Android

Issue description

I'm running MakeCredential: Platform tests and the TPM tests in particular seem to have trouble with validating the certificate path, starting with the first two certs in x5c:

Getting statement for a7d6d93a-8a0d-11e8-9a94-a6cf71072f73
Sub. Iss.: /C=US/ST=MY/L=Wakefield/O=FIDO Alliance/OU=CWG/CN=FIDO Fake TPM Root Certificate Authority 2018/E=conformance-tools@fidoalliance.org
Iss. Sub.: /CN=Sample Attestation Root/O=FIDO Alliance/OU=UAF TWG,/L=Palo Alto/ST=CA/C=US
RP - attestation: Could not validate certificate path with any metadata root certificates (TPM)

Getting statement for f244b67e-5364-4fd5-9f90-c396227317db
Successfully validated attestation with metadata

Getting statement for a7d6d93a-8a0d-11e8-9a94-a6cf71072f73
Sub. Iss.: /C=US/ST=MY/L=Wakefield/O=FIDO Alliance/OU=CWG/CN=FIDO Fake TPM Root Certificate Authority 2018/E=conformance-tools@fidoalliance.org
Iss. Sub.: /CN=Sample Attestation Root/O=FIDO Alliance/OU=UAF TWG,/L=Palo Alto/ST=CA/C=US
RP - attestation: Could not validate certificate path with any metadata root certificates (TPM)

Getting statement for a7d6d93a-8a0d-11e8-9a94-a6cf71072f73
Sub. Iss.: /C=US/ST=MY/L=Wakefield/O=FIDO Alliance/OU=CWG/CN=FIDO Fake TPM Root Certificate Authority 2018/E=conformance-tools@fidoalliance.org
Iss. Sub.: /CN=Sample Attestation Root/O=FIDO Alliance/OU=UAF TWG,/L=Palo Alto/ST=CA/C=US
RP - attestation: Could not validate certificate path with any metadata root certificates (TPM)

Getting statement for a7d6d93a-8a0d-11e8-9a94-a6cf71072f73
Sub. Iss.: /C=US/ST=MY/L=Wakefield/O=FIDO Alliance/OU=CWG/CN=FIDO Fake TPM Root Certificate Authority 2018/E=conformance-tools@fidoalliance.org
Iss. Sub.: /CN=Sample Attestation Root/O=FIDO Alliance/OU=UAF TWG,/L=Palo Alto/ST=CA/C=US
RP - attestation: Could not validate certificate path with any metadata root certificates (TPM)

Getting statement for a7d6d93a-8a0d-11e8-9a94-a6cf71072f73
Sub. Iss.: /C=US/ST=MY/L=Wakefield/O=FIDO Alliance/OU=CWG/CN=FIDO Fake TPM Root Certificate Authority 2018/E=conformance-tools@fidoalliance.org
Iss. Sub.: /CN=Sample Attestation Root/O=FIDO Alliance/OU=UAF TWG,/L=Palo Alto/ST=CA/C=US
RP - attestation: Could not validate certificate path with any metadata root certificates (TPM)

The cert path is invalid based just on the first two certificates - the root cert is never evaluated in the above failures.

Here's a cert chain I pulled from one of the failures:

ynojima commented 2 years ago

@herrjemand As far as I check with v1.6.46, this issue still exists.

yackermann commented 2 years ago

@ynojima Try latest 1.6.48 https://builds.fidoalliance.org/Desktop%20UAF%20FIDO2%20U2F/EXPERIMENTAL/v1.6.48/

aseigler commented 2 years ago

v1.6.48 didn't help. Same issue.

aseigler commented 2 years ago

The CRL at this URL: https://pki.certinfra.fidoalliance.org/tpm/crl/FIDO%20Fake%20TPM%20Root%20Certificate%20Authority%202018.crl

$ openssl crl -in 'FIDO Fake TPM Root Certificate Authority 2018.crl' -text
Certificate Revocation List (CRL):
        Version 2 (0x1)
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = US, ST = MY, L = Wakefield, O = FIDO Alliance, OU = CWG, CN = FIDO Fake TPM Root Certificate Authority 2018, emailAddress = conformance-tools@fidoalliance.org
        Last Update: Feb  1 00:00:00 2018 GMT
        Next Update: Feb  1 00:00:00 2020 GMT
        CRL extensions:
            X509v3 CRL Number:
                1
            X509v3 Authority Key Identifier:
                keyid:43:11:16:99:9A:EE:9D:50:37:C2:4F:FE:E2:5B:15:C9:09:33:3F:32

Is signed with this from the conformance metadata file Virtual RSA PKCS 1.5 SHA256 FIDO2 Conformance Testing CTAP2 Authenticator with TPM Attestation.json under attestationRootCertificates:

$ openssl x509 -in tpmroot.cer -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            8b:c2:5c:12:8b:13:42:d2
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = US, ST = MY, L = Wakefield, O = FIDO Alliance, OU = CWG, CN = FIDO Fake TPM Root Certificate Authority 2018, emailAddress = conformance-tools@fidoalliance.org
        Validity
            Not Before: Apr 25 05:45:38 2019 GMT
            Not After : Sep 10 05:45:38 2046 GMT
        Subject: C = US, ST = MY, L = Wakefield, O = FIDO Alliance, OU = CWG, CN = FIDO Fake TPM Root Certificate Authority 2018, emailAddress = conformance-tools@fidoalliance.org
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                RSA Public-Key: (4096 bit)
                Modulus:
                `snipped for brevity`
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Basic Constraints: critical
                CA:TRUE
            X509v3 Key Usage: critical
                Digital Signature, Certificate Sign
            X509v3 Subject Key Identifier:
                43:11:16:99:9A:EE:9D:50:37:C2:4F:FE:E2:5B:15:C9:09:33:3F:32

The authority key identifier on the CRL matches the subject key identifier on the certificate, but the X509v3 Key Usage extension only has digitalSignature and keyCertSign, it is missing cRLSign which means it cannot be accepted as a CRL signer.

Additionally, the CRL in question and the one at https://pki.certinfra.fidoalliance.org/tpm/crl/NCU-NTC-KEYID-FF990338E187079A6CD6A03ADC57237445F6A49A.crl are currently expired.

ThaminduDilshan commented 2 years ago

@herrjemand any update regarding this test failure? Seems not fixed with v1.6.48

Spomky commented 2 years ago

What about the v1.7.0?

aseigler commented 2 years ago

This is still an issue in v1.7.2, same issue as I outlined prior above.

yackermann commented 2 years ago

Did you update metadata?

On Thu, 21 Jul 2022 at 9:03 PM, Alex Seigler @.***> wrote:

This is still an issue in v1.7.2, same issue as I outlined prior above.

— Reply to this email directly, view it on GitHub https://github.com/fido-alliance/conformance-test-tools-resources/issues/618#issuecomment-1191783155, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMPOFGYJPUEXHUOS37JKILVVGGITANCNFSM5CSUBQVA . You are receiving this because you were mentioned.Message ID: <fido-alliance/conformance-test-tools-resources/issues/618/1191783155@ github.com>

-- Yuriy Ackermann FIDO, Identity, Standards skype: ackermann.yuriy github: @herrjemand https://github.com/herrjemand twitter: @herrjemand https://twitter.com/herrjemand medium: @herrjemand @.***>

aseigler commented 2 years ago

Did you update metadata? Yes, didn't change anything. The second cert in the attestationRootCertificates in the Virtual RSA PKCS 1.5 SHA256 FIDO2 Conformance Testing CTAP2 Authenticator with TPM Attestation.json file is the CRL signer for https://pki.certinfra.fidoalliance.org/tpm/crl/FIDO%20Fake%20TPM%20Root%20Certificate%20Authority%202018.crl and the cert does not have cRLSign key usage set, meaning it is not allowed to sign the CRL. Additionally, the CRL is expired.

aseigler commented 2 years ago

ThaminduDilshan commented 2 years ago

Any update on resolution for this issue?

Kieun commented 2 years ago

Still has same issue in v1.7.6

All certificate path validation for the tpm attestation fails.
Plus, Android safetynet attestation also fails to verify the trust chain.

Kieun commented 2 years ago

@herrjemand is there any update on this issue? This issue blocks our interop testing plans.

yackermann commented 1 year ago

Ok... how about now? https://builds.fidoalliance.org/Desktop%20UAF%20FIDO2%20U2F/v1.7.7/

Kieun commented 1 year ago

@herrjemand let me check them again. Anyway, thanks for your effort. I'll give you the feedbacks.

ptravers-byid commented 1 year ago

@herrjemand we are still seeing the same issue with the certificates in 1.7.7

Milton-Ch commented 1 year ago

@herrjemand Testing with version 1.7.7 I usually pass all tests with TPM. But from 1.7.8 onwards I have the same problem with certificates as reported in this issue.

Kieun commented 1 year ago

This issue seems to be resolved in v1.7.11.

yackermann commented 1 year ago

Based on the recent feedback this issue resolved since 1.7.10

fido-alliance / conformance-test-tools-resources