fido-alliance / conformance-test-tools-resources

Certification Test Tools Resources. For security and privacy related issues email tools@certification.fidoalliance.org
https://fidoalliance.org/certification/functional-certification/conformance/
43 stars 14 forks source link

Missing common IDL in FIDO2 sever conformance API doc #670

Closed MihirLuthra closed 2 years ago

MihirLuthra commented 2 years ago

By submitting this issue you are acknowledging that any information regarding this issue will be publicly available.

If you have privacy concerns, please email conformance-tools@fidoalliance.org

FIRST PRE CHECK

What protocol are you implementing?

Issue description

The conformance test document mentions that ServerAuthenticatorResponse should be in the common IDL. But it is not described there.

Note that the ServerAuthenticatorAttestationResponse extends the generic ServerAuthenticatorResponse, which is described in the Common section below

The only field that this common IDL should have is clientDataJSON. It is already described in the inheriting models. So, I think either the above line should be modified or a common IDL should be added.

yackermann commented 2 years ago

@MihirLuthra Here is a full description of the conformance api https://github.com/fido-alliance/conformance-test-tools-resources/blob/master/docs/FIDO2/Server/Conformance-Test-API.md

MihirLuthra commented 2 years ago

@herrjemand I already attached that link in my issue description. The conformance API claims to specify a model named "ServerAuthenticatorResponse" in its common section but doesn't do that. It's not really a big problem but thought I should mention.

It's possible that I missed some point (sorry if that's the case) but I would request you to re-read the issue description once.

yackermann commented 2 years ago

ServerAuthenticatorResponse is a placeholder object.