fido-alliance / conformance-test-tools-resources

Certification Test Tools Resources. For security and privacy related issues email tools@certification.fidoalliance.org
https://fidoalliance.org/certification/functional-certification/conformance/
40 stars 14 forks source link

Missing pinUvAuthToken fetch in Authr-CredentialManagement-EnumerateRPs Test P-2 #714

Closed nagreme closed 1 year ago

nagreme commented 1 year ago

By submitting this issue you are acknowledging that any information regarding this issue will be publicly available.

If you have privacy concerns, please email conformance-tools@fidoalliance.org

FIRST PRE CHECK

What protocol are you implementing?

NOTE: UAF 1.0 certification have been officially sunset. U2F 1.2 only supported version of U2F.

What is your implementation class?

If you are platform authenticator vendor, please email conformance-tools@fidoalliance.org

What is the version of the tool are you using?

v1.7.11

What is the OS and the version are you running?

For desktop tools

For UAF mobile tools

Issue description

Authr-CredentialManagement-EnumerateRPs Test P-2 was passing on 1.7.10 but is now failing on 1.7.11 (same authenticator implementation) with pin auth invalid error (CTAP2_ERR_PIN_AUTH_INVALID).

Cause seems to be that the test in the 1.7.11 version of the tool doesn't re-fetch the pinUvAuthToken (Generating test PUAT..., i.e. getKeyAgreement + getPinToken) before sending the request unlike other tests in the same category.

v1.7.10

image

v1.7.11

image

If we can just add that back in the test it would resolve this.

Otherwise if this removal was intentional can you provide an explanation/reason?

yackermann commented 1 year ago

@nagreme is that for NFC?

yackermann commented 1 year ago

Otherwise:

P1 - Runs all necessary pre-sets, and initiates enumeration P2 - Actually calls GetNextRP.

P1 uses PUAT to inialise RP enumeration, while P2 simply continues to call for next entry, which does not require PUAT

nagreme commented 1 year ago

@nagreme is that for NFC?

Yes, it is for NFC

yackermann commented 1 year ago

ok, I am trying to reproduce but having problem. What reader do you have?

nagreme commented 1 year ago

I have the same error on both:

Also if it's relevant, I am using a smart card not a usb token with NFC

yackermann commented 1 year ago

Ok, confirmed and resolved.!

nagreme commented 1 year ago

Awesome thank you! 🙂

yackermann commented 1 year ago

latest build: https://builds.fidoalliance.org/Desktop%20UAF%20FIDO2%20U2F/v1.7.14/