fido-alliance / conformance-test-tools-resources

Certification Test Tools Resources. For security and privacy related issues email tools@certification.fidoalliance.org
https://fidoalliance.org/certification/functional-certification/conformance/
40 stars 14 forks source link

Adopt residentKey param deprecating requireResidentKey #717

Closed mkkhedawat closed 7 months ago

mkkhedawat commented 1 year ago

By submitting this issue you are acknowledging that any information regarding this issue will be publicly available.

If you have privacy concerns, please email conformance-tools@fidoalliance.org

FIRST PRE CHECK

The old issue is outdated and closed - https://github.com/fido-alliance/conformance-test-tools-resources/issues/676

What protocol are you implementing?

NOTE: UAF 1.0 certification have been officially sunset. U2F 1.2 only supported version of U2F.

What is your implementation class?

If you are platform authenticator vendor, please email conformance-tools@fidoalliance.org

What is the version of the tool are you using?

v1.7.14

What is the OS and the version are you running?

For desktop tools

For UAF mobile tools

Issue description

Test which checks for requireResidentKey fails -

AssertionError: Response.authenticatorSelection MUST be set to the requested authenticatorSelection! Expected "{"residentKey":"preferred","userVerification":"preferred"}" to equal "{"requireResidentKey":false,"userVerification":"preferred"}": expected { Object (residentKey, userVerification) } to deeply equal { Object (requireResidentKey, userVerification) }
    at n.eval (eval at compileCode (js/sandbox.js:25:26), <anonymous>:4529:16)

Now that requireResidentKey is deprecated in favour of discoverable credentials, Can we please update the test ?

[PS - This tool is fantastic and act as primary layer of testing for me]

pheimfido commented 9 months ago

Updated assignees: removed Yuriy Ackermann, assigned @iirachek