fido-alliance / conformance-test-tools-resources

Certification Test Tools Resources. For security and privacy related issues email tools@certification.fidoalliance.org
https://fidoalliance.org/certification/functional-certification/conformance/
40 stars 14 forks source link

Probable typo in cryptodep.js@COSE_ALG_HASH #761

Closed serianox closed 2 months ago

serianox commented 3 months ago

By submitting this issue you are acknowledging that any information regarding this issue will be publicly available.

If you have privacy concerns, please email conformance-tools@fidoalliance.org

FIRST PRE CHECK

What protocol are you implementing?

NOTE: UAF 1.0 certification have been officially sunset. U2F 1.2 only supported version of U2F.

What is your implementation class?

If you are platform authenticator vendor, please email conformance-tools@fidoalliance.org

What is the version of the tool are you using?

1.7.19-1

What is the OS and the version are you running?

For desktop tools

For UAF mobile tools

Issue description

It seems there's a typo in in the hash computation for es384.

Hash computation fails with "Error: hashFunction argument is missing!"

In cryptodep.js@COSE_ALG_HASH, ECDSA w/ SHA-384 and SHA-512 are referenced as -36 and -37 resp, whereas in https://www.iana.org/assignments/cose/cose.xhtml they are referenced as -35 and -36 resp.

iirachek commented 3 months ago

Fixed, will be included in the upcoming v1.7.20

serianox commented 2 months ago

Tested OK with 1.7.20-4. 👍

Should I close the issue?