[BUG] http: panic serving [::1]:62756: runtime error: invalid memory address or nil pointer dereference

[quanvincss]

To simplify issue resolution process, please provide network logs, and or test voucher.

2023/06/21 00:50:38 --- 20 FIDO_RVT_21_CHECK_RESP. Sending buffer 80
2023/06/21 00:50:38 --- 20 FIDO_RVT_21_CHECK_RESP. HTTP 200 Receiving buffer 8150e0de3de695950080a488482ec36718d4 

2023/06/21 00:50:38 http: panic serving [::1]:62756: runtime error: invalid memory address or nil pointer dereference
goroutine 122 [running]:
net/http.(*conn).serve.func1()
        /Users/thaodtp/sdk/go1.19.5/src/net/http/server.go:1850 +0xb0
panic({0x102c27c40, 0x1030baeb0})
        /Users/thaodtp/sdk/go1.19.5/src/runtime/panic.go:890 +0x258
github.com/fido-alliance/fdo-fido-conformance-server/core/do/to0.(*To0Requestor).confCheckResponse(0x102a8b9ef?, {0x14002a2e000, 0x12, 0x200}, {0x102a8b9ef, 0x16}, 0x102a8b914?)

What part of the spec are you testing?

• [ ] Rendezvous Server
• [x] Device Onboarding Service
• [ ] Device Implementation

What protocol are having issue with?

• [x] TO0
• [ ] TO1
• [ ] TO2

Issue description

• Panic error with test case FIDO_RVT_21_CHECK_RESP and FIDO_RVT_23_CHECK_RESP
• I found wrong if conditions in https://github.com/fido-alliance/fdo-fido-conformance-server/blob/650e1441ed6239e72ecd94d6f1d68fe8db246e16/core/do/to0/common.go#L80 and https://github.com/fido-alliance/fdo-fido-conformance-server/blob/650e1441ed6239e72ecd94d6f1d68fe8db246e16/core/do/to0/common.go#L94

[yackermann]

Good catch! Thx!