search

fido-alliance / iot-fdo-conformance-tools

FIDO Alliances Reference FDO Implementation and Conformance Testing
https://fidoalliance.org/intro-to-fido-device-onboard/
Other
5 stars 2 forks source link

[BUG] TO2: Unsupported test for all FIDO_TEST_LIST_VOUCHER #41

Open quanvincss opened 1 year ago

quanvincss commented 1 year ago

To simplify issue resolution process, please provide network logs, and or test voucher.

image

What part of the spec are you testing?

What protocol are having issue with?

Issue description

The conformance server does not check response for group test FIDO_TEST_LIST_VOUCHER https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/core/device/to2/to2-common.go#L44

yackermann commented 1 year ago

Try deleting badgerdb and re-seed it via ./fdo-fido-conformance-server seed

quanvincss commented 1 year ago

Try deleting badgerdb and re-seed it via ./fdo-fido-conformance-server seed

It does not seem to be a DB issue, in To2 test, FIDO_TEST_LIST_VOUCHER is used in executeTo2_60_Vouchers: https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/testexec/do.to2.60.vouchers.execute.go#L13

inside that function, you call to2requestor.HelloDevice60: https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/testexec/do.to2.60.vouchers.execute.go#L30

then in HelloDevice60, you send msg60 request and check response in confCheckResponse: https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/core/device/to2/req-to2-60-HelloDevice.go#L40

but inside function confCheckResponse, you didn't check response for FIDO_TEST_LIST_VOUCHER and it returns "false" by default: https://github.com/fido-alliance/fdo-fido-conformance-server/blob/bed48409e41da82fc603fa89ef645ca8cc5acb14/core/device/to2/to2-common.go#L65