[BUG] testexec.executeTo2_64 bugs - Githubissues

fido-alliance / iot-fdo-conformance-tools

FIDO Alliances Reference FDO Implementation and Conformance Testing

https://fidoalliance.org/intro-to-fido-device-onboard/

Other

5 stars 2 forks source link

[BUG] testexec.executeTo2_64 bugs #53

Closed quanvincss closed 1 year ago

quanvincss commented 1 year ago

To simplify issue resolution process, please provide network logs, and or test voucher.

What part of the spec are you testing?

[ ] Rendezvous Server
[x] Device Onboarding Service
[ ] Device Implementation

What protocol are having issue with?

[ ] TO0
[ ] TO1
[x] TO2

Issue description

Test list for msg60 is used instead of msg64 https://github.com/fido-alliance/fdo-fido-conformance-server/blob/6d23facb23ff9012ab77fc8b96aeba015f16d683/testexec/do.to2.64.execute.go#L61
There is no mention of test case FIDO_DOT_64_BAD_ENCODING and FIDO_DOT_64_BAD_EAT_PAYLOAD

quanvincss commented 1 year ago

@herrjemand this issue is not resolved yet, these test cases FIDO_DOT_64_BAD_ENCODING and FIDO_DOT_64_BAD_EAT_PAYLOAD are in the test list but you didn't make any confusion for them, therefore the conformance server sends valid requests and expects error response.