fido-alliance / iot-fdo-conformance-tools

FIDO Alliances Reference FDO Implementation and Conformance Testing
https://fidoalliance.org/intro-to-fido-device-onboard/
Other
5 stars 2 forks source link

[BUG] Failure when parsing EMBlock protected header #54

Closed quanvincss closed 1 year ago

quanvincss commented 1 year ago

To simplify issue resolution process, please provide network logs, and or test voucher. Msg65 response body: 8343a10101a1054cbf2ca96d7a81bfe3e67beb7d58e3dc6ba21ac9094a7a5b0f09f96527f4902544692c7c720197bd58ec184126bd8f6dcb9e656fbb4759cf2f6844ab53c9484c1a99d0302da52167e369b7d0da5b1942b8d770c45d29bd89e6b44892164f24ebd031bef1e128b95c3df01aeca13aafb933c36e29029fcc7b9c3ca4f0418378765a0e775e15ba91bac24f6af666b626b734f02cd083709f18440c5ebf6390cf8106ce33fc4a6d6414698e134b32dcb52a73cba27a2bdb2d6048f16fc7961eac8a91753b5e0fda9a3298d73a7086f77c4ef583609771df195b626780a630554365f872905a6dfc5706852e35f4e8cc5a753ef4

Msg65 test result from conformance server:

image

What part of the spec are you testing?

What protocol are having issue with?

Issue description

Protected header in EMBlock struct is defined as map object instead of bytes array as defined in #6.16 https://www.rfc-editor.org/rfc/rfc8152#section-5.2 https://github.com/fido-alliance/fdo-fido-conformance-server/blob/6d23facb23ff9012ab77fc8b96aeba015f16d683/core/shared/enc.crypto.go#L391

quanvincss commented 1 year ago

Sorry, I misunderstood the CDDL.

yackermann commented 1 year ago

Haha. No worries @quanvincss

quanvincss commented 1 year ago

Hi @herrjemand, I reopen this issue as @GeofCooper said in Discord

image
yackermann commented 1 year ago

Yes, @GeofCooper is correct.

However this needs to be properly addressed in the spec, and not just a tech note.

cc @pheimfido

yackermann commented 1 year ago

This is now addressed