fido-alliance / iot-fdo-conformance-tools

FIDO Alliances Reference FDO Implementation and Conformance Testing
https://fidoalliance.org/intro-to-fido-device-onboard/
Other
5 stars 2 forks source link

[BUG] Msg66: Cose tag in CoseEncrypt0 is missing #59

Closed quanvincss closed 1 year ago

quanvincss commented 1 year ago

To simplify issue resolution process, please provide network logs, and or test voucher. Request body device onboarding service received from conformance server:

2023-10-05T05:49:06.730Z [OWNER_SERVER] f1d0fd00578b42ffb34c1a2b62223455 info: TO2.DeviceServiceInfoReady66 Request Body: 83a10101a1054c8fe240491f4e069683a797cc5848b432711b151d7e6e4ee5157464616af923ea4e81985e371565e8ba01a958ce8c5b1f54e5c5f5082266aa3c2b324bb444ff0ba7368d26351ef2ea5fa19574dd1463ea90f27b2fddf3 
2023-10-05T05:49:06.734Z [OWNER_SERVER] f1d0fd00578b42ffb34c1a2b62223455 error: Failed to read tag

What part of the spec are you testing?

What protocol are having issue with?

Issue description

quanvincss commented 1 year ago

Hi @herrjemand, this issue is not resolved yet, it is not acceptable to add the same tag number with different types to the TagSet, you will see if you check error here: https://github.com/fido-alliance/iot-fdo-conformance-tools/blob/965603d67bace4edbd3f88eb8ad4724531e96364/core/shared/cbor.go#L47

yackermann commented 1 year ago

Addressed