[BUG] Error in encryption / decryption for ciphersuites A256GCM and AES-CCM-64-128-256 - Githubissues

fido-alliance / iot-fdo-conformance-tools

FIDO Alliances Reference FDO Implementation and Conformance Testing

https://fidoalliance.org/intro-to-fido-device-onboard/

Other

5 stars 2 forks source link

[BUG] Error in encryption / decryption for ciphersuites A256GCM and AES-CCM-64-128-256 #61

Closed Sai-Anudeep47 closed 1 year ago

Sai-Anudeep47 commented 1 year ago

To simplify issue resolution process, please provide network logs, and or test voucher.

What part of the spec are you testing?

[ ] Rendezvous Server
[ ] Device Onboarding Service
[x] Device Implementation

What protocol are having issue with?

[ ] TO0
[ ] TO1
[x] TO2

Issue description

Incorrect PRF is used for KDF and there is a miss in fixing this for encrypt/decrypt EMB functions. At https://github.com/fido-alliance/iot-fdo-conformance-tools/blob/main/core/shared/enc.crypto.go#L441 and https://github.com/fido-alliance/iot-fdo-conformance-tools/blob/main/core/shared/enc.crypto.go#L491 it is still using

alg.HmacAlg

instead of

alg.KdfHmacAlg

This is related to #51