fido-alliance / webauthn-demo

WebAuthn Workshop Demo [Completed DEMO is at completed demo-branch]
MIT License
733 stars 152 forks source link

isCA check error, noticed when using typescript #30

Open agmcleod opened 2 years ago

agmcleod commented 2 years ago

I think the line here: https://github.com/fido-alliance/webauthn-demo/blob/a32c36c7f032821bdf30ec40c677bb55c36d7031/utils.js#L259 is incorrect. I've been pulling in some of this code into a demo/prototype project. I'm using typescript, and was able to reference the types for the x509 package. The typescript compiler noted how isCA is not a field on the Extension[] field. I think this can be changed to use the isCA field on the pem object instead. The library sifts through the extensions and updates the boolean based on what it finds here: https://github.com/fidm/x509/blob/master/src/x509.ts#L393