Closed retorquere closed 7 years ago
Aw, yeah! I have a post-processing workaround for this and other than that all my non-synthetic import tests pass!
Oh yeah it would be really useful if you could release a new version to npm :)
Ok. I would also be ok with adding the two line max limit in the parser. I just didn't have time today.
No worries. What I have works, I prefer it would be done on the parser, but you've already done so much. I'm just happy with the current state of affairs, import was a huge effort but fully worth it and I'm one step further towards a working and cleaner bbt.
Ok, I fixed it in the parser. And you have your new version.
@retorquere I noticed we still have lots comments saying "% TODO: verify output" in the test bib-files. Does that mean that these files haven't been tested yet?
I dropped that into every test file at some point but must admit I haven't thought about it since so I can't say what the current state on each is... but the last 911 test cases I went through one-by-one and that should be pretty good coverage (also seeing the activity in the past period).
ok. well, feel free to delete them whenever you have checked a particular file
I've cleaned up the todo comment for all the files we touched in the past week -- which happened to be all the files that had the todo comment.
Ok, so should we make a new version with everything fixed now? Version 0.27 or 1.0?
Semantically nothing has changed, right? So semver would say 0.27, although 1.0 would signify the milestone we reached better.
Right. But does semver then say that all software that never changes public API should always stay < 1?
To me, 0.X signifies that the software has not yet reached production level stability. 1.x signifies that it has.
I suppose the first is a conclusion you could draw from that :)
I'm not too hung up on semver, and I agree with the 0.x "vibe".
I think rule 5 in semver kind of says that semver rules only kick in starting version 1.0.0?
You're right, pre-1 rules are different. 1.0 it is then.
done!
I still see only 0.26.0 on npmjs?
uh. I'll restart the build. Hopefully that works. Otherwise we'll have to go back to manual pushes to npm.
Doesn't look like it did.
I found the reason: Travis has upgraded everyone from precise to trusty as of September 2017. And apparently their trusty environment works slightly different and doesn't keep the development dependencies for deployment.... annoying. Working on solution now. I will like be about v. 1.0.5 that will work again.
That's a nuisance but only a minor one for me. I don't expect new testcases before I release, and I've just peeked into my commit history and I've been at the port about two months now pretty much full time... and I'm only two thirds through before beta... so...
yeah, it will be there tonight, but the version number may end up being 1.0.5 or 1.0.10 or something like that. But unless I tag a release, travis won't even try to publish it. So I made a 1.0.1, making a small adjustment that didn't work... now I made a 1.0.2 with another adjustment, etc. . I don't think there is any other way to debug it and it doesn't look like this is a common issue. Probably most have switched to trusty a while ago. I didn't know we were on precise until just now.
1.0.5 has been released on npm.
And has been picked up and (as expected) passes all my tests.
In this reference
there should be two newlines between
materials.
andThe aim
in the parsed structure.