Using `redirectToLogin` on an unknown workspace silently fail - Githubissues

fief-dev / fief-js

Fief client for JavaScript

https://docs.fief.dev/integrate/javascript/

MIT License

9 stars 3 forks source link

Using `redirectToLogin` on an unknown workspace silently fail #7

Closed tito closed 1 year ago

tito commented 1 year ago

Describe the bug

If you use fiefAuth.redirectToLogin(...), and the workspace cannot be found, you'll have

getOpenIDConfiguration() receive an error HTTP 400 with content {"detail":"CANT_DETERMINE_VALID_WORKSPACE"}
no error throw, and the authorizationEndpoint will be undefined

End result is, in your app, you end up with redirecting with an url like http://.../undefined?response_type=code&client_id=.... And no clue why :)

To Reproduce

Steps to reproduce the behavior:

Start empty instance of fief
Run your code on this instance
See error

Configuration

JavaScript environment: VueJS
Fief client version: 0.13.3

frankie567 commented 1 year ago

Good catch, @tito, thanks 🙏

I've added proper error handling for this in 0.13.5. You can look for FiefRequestError for those cases.