search

fief-dev / fief-python

Fief client for Python
https://docs.fief.dev/integrate/python/
MIT License
11 stars 4 forks source link

Unhandled error printout with cli client #18

Closed fubuloubu closed 1 month ago

fubuloubu commented 1 month ago

Describe the bug

I followed the docs for the cli version of the client (which works!), however it seems like an unhandled exception towards the end of that process keeps printing to the console

To Reproduce

Followed steps from here: https://docs.fief.dev/integrate/python/cli/

In [3]: client.authorize()
Out [3]: ...  # access_token stuff
Error in callback <function Halo.__init__.<locals>.clean_up at 0x744c898153a0> (for post_run_cell), with arguments args (<ExecutionResult object at 744c898249d0, ...
TypeError: Halo.__init__.<locals>.clean_up() takes 0 positional arguments but 1 was given

Expected behavior

Doesn't appear to affect operation, but is annoying to see this error no matter what is happening lol

Configuration

Additional context

Very sweet having a CLI client! (need it for our use case)

fubuloubu commented 1 month ago

related: https://github.com/manrajgrover/halo/pull/180

halo seems unmaintained

fubuloubu commented 1 month ago

This seems much more active: https://pypi.org/project/yaspin/

frankie567 commented 1 month ago

Good catch, thank you! Would be happy to review a PR replacing halo by yaspin :)

fubuloubu commented 1 month ago

Good catch, thank you! Would be happy to review a PR replacing halo by yaspin :)

Yeah will do, this seems like an easy migration lol