fief-dev / fief-python

Fief client for Python
https://docs.fief.dev/integrate/python/
MIT License
12 stars 4 forks source link

fix: replace halo with yaspin #19

Closed johnson2427 closed 4 months ago

johnson2427 commented 4 months ago

Description

Fixes #18 This is a change to fief-python

Halo is used to produce the spinner in the cli and IPython. This causes an error, and since halo is no longer maintained, we have replaced halo with yaspin

johnson2427 commented 4 months ago

Had an error in testing, I have all tests passing locally, hoping the last push gets us there

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b25db81) to head (d7905fc).

:exclamation: Current head d7905fc differs from pull request most recent head a8ae24b

Please upload reports for the commit a8ae24b to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 689 670 -19 ========================================= - Hits 689 670 -19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frankie567 commented 4 months ago

Can you give me rights to edit the PR (Allow edits from maintainer on the right)? I've a fix for failing tests.

fubuloubu commented 4 months ago

Can you give me rights to edit the PR (Allow edits from maintainer on the right)? I've a fix for failing tests.

We looked for a solid 20 minutes and can't figure out where github moved this option ๐Ÿ˜…

Maybe it's some configuration we need to update, but github docs no help there either

frankie567 commented 4 months ago

Normally, it's on the sidebar:

Capture dโ€™eฬcran 2024-06-03 aฬ€ 16 38 25

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

johnson2427 commented 4 months ago

This is what I have over there image

frankie567 commented 4 months ago

Ok! Editing PR from forks is always a nightmare ๐Ÿ˜… I'll merge it as it and apply my changes on the main branch.

Thank you for the work on this ๐Ÿ™