search

fief-dev / fief

Users and authentication management SaaS
https://www.fief.dev
Other
488 stars 42 forks source link

Role update fails to send task to worker #189

Closed frankie567 closed 1 year ago

frankie567 commented 1 year ago

Faulty code:

https://github.com/fief-dev/fief/blob/0d39811a421713ece288644cb5ac0d21ac165ae3/fief/apps/dashboard/routers/roles.py#L188-L194

set objects are not encodable by the JSON encoder of Dramatiq.

The error is not catched by unit tests because send_task is fully mocked. This needs to be improved as well so we can catch this kind of errors.

Sentry: https://fief.sentry.io/issues/4182696675/events/b382c75c7647401c9c5c0d4770e124d7/